[all-commits] [llvm/llvm-project] 2add7c: [llvm-ar][Object] Fix detection of need for 64-bit...

[Andrew Ng via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 2add7c5cf3ebbba629d2756b3e91728e55b40881
      https://github.com/llvm/llvm-project/commit/2add7c5cf3ebbba629d2756b3e91728e55b40881
  Author: Andrew Ng <andrew.ng at sony.com>
  Date:   2020-10-26 (Mon, 26 Oct 2020)

  Changed paths:
    M llvm/lib/Object/ArchiveWriter.cpp
    M llvm/test/Object/archive-symtab.test

  Log Message:
  -----------
  [llvm-ar][Object] Fix detection of need for 64-bit archive symbol tables

The code to detect the requirement for 64-bit offsets in the archive
symbol table was not correctly accounting for the archive file signature
and the size of all the contents of the symbol table itself, e.g. the
symbol table's header and string table. Also was not considering the
variation in symbol table formats. This could result in the creation of
large archives with a corrupt symbol table.

Change the testing environment variable SYM64_THRESHOLD to be an
absolute value rather than a power of 2 in order to enable precise
testing of this detection code.

Differential Revision: https://reviews.llvm.org/D89891