[all-commits] [llvm/llvm-project] cf593d: SourceManager: getFileEntryRefForID => getNonBuilt...

[Duncan P. N. Exon Smith via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: cf593d224c9c3fc2cf93827cb66fd9e550a6a486
      https://github.com/llvm/llvm-project/commit/cf593d224c9c3fc2cf93827cb66fd9e550a6a486
  Author: Duncan P. N. Exon Smith <dexonsmith at apple.com>
  Date:   2020-10-22 (Thu, 22 Oct 2020)

  Changed paths:
    M clang/include/clang/Basic/SourceManager.h
    M clang/lib/Basic/SourceManager.cpp
    M clang/lib/Frontend/DependencyFile.cpp
    M clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp

  Log Message:
  -----------
  SourceManager: getFileEntryRefForID => getNonBuiltinFilenameForID, NFC

`SourceManager::getFileEntryRefForID`'s remaining callers just want the
filename component, which is coming from the `FileInfo`. Replace the API
with `getNonBuiltinFilenameForID`, which also removes another use of
`FileEntryRef::FileEntryRef` outside of `FileManager`.

Both callers are collecting file dependencies, and one of them relied on
this API to filter out built-ins (as exposed by
clang/test/ClangScanDeps/modules-full.cpp). It seems nice to continue
providing that service.

Differential Revision: https://reviews.llvm.org/D89508


  Commit: 3b8d8954bf2c192502d757019b9fe434864068e9
      https://github.com/llvm/llvm-project/commit/3b8d8954bf2c192502d757019b9fe434864068e9
  Author: Duncan P. N. Exon Smith <dexonsmith at apple.com>
  Date:   2020-10-22 (Thu, 22 Oct 2020)

  Changed paths:
    M clang/lib/Basic/SourceManager.cpp

  Log Message:
  -----------
  SourceManager: Remove a redundant nullptr check in getNonBuiltinFilenameForID, NFC


Compare: https://github.com/llvm/llvm-project/compare/27e11d7120c0...3b8d8954bf2c