[all-commits] [llvm/llvm-project] 147b94: [AArch64][GlobalISel] Split post-legalizer combine...

[Jessica Paquette via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 147b9497e79a98a8614b2b5eb4ba653b44f6b6f0
      https://github.com/llvm/llvm-project/commit/147b9497e79a98a8614b2b5eb4ba653b44f6b6f0
  Author: Jessica Paquette <jpaquette at apple.com>
  Date:   2020-10-22 (Thu, 22 Oct 2020)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64.h
    M llvm/lib/Target/AArch64/AArch64Combine.td
    M llvm/lib/Target/AArch64/AArch64TargetMachine.cpp
    M llvm/lib/Target/AArch64/CMakeLists.txt
    M llvm/lib/Target/AArch64/GISel/AArch64PostLegalizerCombiner.cpp
    A llvm/lib/Target/AArch64/GISel/AArch64PostLegalizerLowering.cpp
    M llvm/lib/Target/AArch64/GISel/AArch64PreLegalizerCombiner.cpp
    R llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-combiner-ext.mir
    R llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-combiner-rev.mir
    R llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-combiner-shuffle-splat.mir
    R llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-combiner-trn.mir
    R llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-combiner-uzp.mir
    R llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-combiner-vashr-vlshr.mir
    R llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-combiner-zip.mir
    A llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-lowering-ext.mir
    A llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-lowering-rev.mir
    A llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-lowering-shuffle-splat.mir
    A llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-lowering-trn.mir
    A llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-lowering-uzp.mir
    A llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-lowering-vashr-vlshr.mir
    A llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-lowering-zip.mir
    M llvm/test/CodeGen/AArch64/O0-pipeline.ll

  Log Message:
  -----------
  [AArch64][GlobalISel] Split post-legalizer combiner to allow for lowering at -O0

There are a lot of combines in AArch64PostLegalizerCombiner which exist to
facilitate instruction matching in the selector. (E.g. matching for G_ZIP and
other shuffle vector pseudos)

It still makes sense to select these instructions at -O0.

Matching earlier in a combiner can reduce complexity in the selector
significantly. For example, a good portion of our selection code for compares
would be a lot easier to represent in a combine.

This patch moves matching combines into a "AArch64PostLegalizerLowering"
combiner which runs at all optimization levels.

Also, while we're here, improve the documentation for the
AArch64PostLegalizerCombiner, and fix up the filepath in its file comment.

And also add a 'r' which somehow got dropped from a bunch of function names.

https://reviews.llvm.org/D89820