[all-commits] [llvm/llvm-project] 26790e: [libomptarget] Require LLVM source tree to build l...

[Jon Chesterfield via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 26790ed248870a1e293e844945bf677825a43084
      https://github.com/llvm/llvm-project/commit/26790ed248870a1e293e844945bf677825a43084
  Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
  Date:   2020-10-21 (Wed, 21 Oct 2020)

  Changed paths:
    M openmp/CMakeLists.txt
    M openmp/libomptarget/CMakeLists.txt
    M openmp/libomptarget/plugins/amdgpu/CMakeLists.txt

  Log Message:
  -----------
  [libomptarget] Require LLVM source tree to build libomptarget

[libomptarget] Require LLVM source tree to build libomptarget

This is to permit reliably #including files from the LLVM tree in libomptarget,
as an improvement on the copy and paste that is currently in use. See D87841
for the first example of removing duplication given this new requirement.

The weekly openmp dev call reached consensus on this approach. See also D87841
for some alternatives that were considered. In the future, we may want to
introduce a new top level repo for shared constants, or start using the ADT
library within openmp.

This will break sufficiently exotic build systems, trivial fixes as below.

Building libomptarget as part of the monorepo will continue to work.
If openmp is built separately, it now requires a cmake macro indicating
where to find the LLVM source tree.

If openmp is built separately, without the llvm source tree already on disk,
the build machine will need a copy of a subset of the llvm source tree and
the cmake macro indicating where it is.

Reviewed By: protze.joachim

Differential Revision: https://reviews.llvm.org/D89426