[all-commits] [llvm/llvm-project] 4b7daf: [mlir]: Clarify docs for external OpTrait::Functio...

Frej Drejhammar via All-commits all-commits at lists.llvm.org
Wed Oct 21 09:08:32 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 4b7dafd9046f0ceaadacaafe0ea4a1fb00cf70a5
      https://github.com/llvm/llvm-project/commit/4b7dafd9046f0ceaadacaafe0ea4a1fb00cf70a5
  Author: Frej Drejhammar <frej.drejhammar at gmail.com>
  Date:   2020-10-21 (Wed, 21 Oct 2020)

  Changed paths:
    M mlir/docs/Traits.md
    M mlir/include/mlir/IR/FunctionSupport.h

  Log Message:
  -----------
  [mlir]: Clarify docs for external OpTrait::FunctionLike ops

The documentation claims that an op with the trait FunctionLike has a
single region containing the blocks that corresponding to the body of
the function. It then goes on to say that the absence of a region
corresponds to an external function when, in fact, this is represented
by a single empty region. This patch changes the wording in the
documentation to match the implementation.

Signed-off-by: Frej Drejhammar <frej.drejhammar at gmail.com>
Co-authored-by: Frej Drejhammar <frej.drejhammar at gmail.com>
Co-authored-by: Klas Segeljakt <klasseg at kth.se>

Reviewed By: ftynse

Differential Revision: https://reviews.llvm.org/D89868




More information about the All-commits mailing list