[all-commits] [llvm/llvm-project] fa5fa6: [lldb] Port lldb gdb-server to libOption

Pavel Labath via All-commits all-commits at lists.llvm.org
Wed Oct 21 07:16:47 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: fa5fa63fd140f2d4bad0357839378606a583b32c
      https://github.com/llvm/llvm-project/commit/fa5fa63fd140f2d4bad0357839378606a583b32c
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-10-21 (Wed, 21 Oct 2020)

  Changed paths:
    M lldb/include/lldb/Utility/Args.h
    M lldb/source/Utility/Args.cpp
    A lldb/test/Shell/lldb-server/TestErrorMessages.test
    M lldb/tools/lldb-server/CMakeLists.txt
    A lldb/tools/lldb-server/LLGSOptions.td
    M lldb/tools/lldb-server/lldb-gdbserver.cpp

  Log Message:
  -----------
  [lldb] Port lldb gdb-server to libOption

The existing help text was very terse and was missing several important
options. In the new version, I add a short description of each option
and a slightly longer description of the tool as a whole.

The new option list does not include undocumented no-op options:
--debug and --verbose. It also does not include undocumented short
aliases for long options, with two exceptions: -h, because it's
well-known; and -S (--setsid), as it's used in one test. Using these
options will now produce an error. I believe that is acceptable as users
aren't generally invoking lldb-server directly, and the only way to
learn about the short aliases was by looking at the source.

Differential Revision: https://reviews.llvm.org/D89477




More information about the All-commits mailing list