[all-commits] [llvm/llvm-project] acb33c: [llvm] Fix ODRViolations for VersionTuple YAML spe...
Cyndy Ishida via All-commits
all-commits at lists.llvm.org
Tue Oct 20 18:30:47 PDT 2020
Branch: refs/heads/master
Home: https://github.com/llvm/llvm-project
Commit: acb33cba6d455dd96d82e2b746b2237f283a6416
https://github.com/llvm/llvm-project/commit/acb33cba6d455dd96d82e2b746b2237f283a6416
Author: Cyndy Ishida <cyndy_ishida at apple.com>
Date: 2020-10-20 (Tue, 20 Oct 2020)
Changed paths:
M llvm/include/llvm/Support/YAMLTraits.h
M llvm/lib/InterfaceStub/TBEHandler.cpp
M llvm/lib/Support/YAMLTraits.cpp
M llvm/tools/llvm-ifs/llvm-ifs.cpp
M llvm/unittests/InterfaceStub/ELFYAMLTest.cpp
Log Message:
-----------
[llvm] Fix ODRViolations for VersionTuple YAML specializations NFC
It appears for Swift there was confusing errors when trying to parse APINotes, when libAPINotes and libInterfaceStub are linked, they both export symbol
`__ZN4llvm4yaml7yamlizeINS_12VersionTupleEEENSt3__19enable_ifIXsr16has_ScalarTraitsIT_EE5valueEvE4typeERNS0_2IOERS5_bRNS0_12EmptyContextE`, and discovered
same symbol defined within llvm-ifs.
This consolidates the boilerplate into YAMLTraits and defers the specific validation in reading the whole input.
fixes: rdar://problem/70450563
Reviewed By: phosek, dblaikie
Differential Revision: https://reviews.llvm.org/D89764
More information about the All-commits
mailing list