[all-commits] [llvm/llvm-project] 8a203b: [trace] rename ThreadIntelPT into TraceTrace

walter erquinigo via All-commits all-commits at lists.llvm.org
Mon Oct 19 15:15:22 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 8a203bb22d161d23c6b1195f85ae025e87f03bae
      https://github.com/llvm/llvm-project/commit/8a203bb22d161d23c6b1195f85ae025e87f03bae
  Author: Walter Erquinigo <wallace at fb.com>
  Date:   2020-10-19 (Mon, 19 Oct 2020)

  Changed paths:
    A lldb/include/lldb/Target/ProcessTrace.h
    A lldb/include/lldb/Target/ThreadTrace.h
    M lldb/include/lldb/Target/TraceSessionFileParser.h
    M lldb/include/lldb/lldb-forward.h
    M lldb/source/API/SystemInitializerFull.cpp
    M lldb/source/Plugins/Process/CMakeLists.txt
    R lldb/source/Plugins/Process/Trace/CMakeLists.txt
    R lldb/source/Plugins/Process/Trace/ProcessTrace.cpp
    R lldb/source/Plugins/Process/Trace/ProcessTrace.h
    M lldb/source/Plugins/Trace/intel-pt/CMakeLists.txt
    R lldb/source/Plugins/Trace/intel-pt/ThreadIntelPT.cpp
    R lldb/source/Plugins/Trace/intel-pt/ThreadIntelPT.h
    M lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp
    M lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h
    M lldb/source/Plugins/Trace/intel-pt/TraceIntelPTSessionFileParser.cpp
    M lldb/source/Plugins/Trace/intel-pt/TraceIntelPTSessionFileParser.h
    M lldb/source/Target/CMakeLists.txt
    A lldb/source/Target/ProcessTrace.cpp
    A lldb/source/Target/ThreadTrace.cpp
    M lldb/source/Target/TraceSessionFileParser.cpp

  Log Message:
  -----------
  [trace] rename ThreadIntelPT into TraceTrace

Renamed ThreadIntelPT to TreaceThread, making it a top-level class. I noticed that this class can and shuld work for any trace plugin and there's nothing intel-pt specific in it.
With that TraceThread change, I was able to move most of the json file parsing logic to the base class TraceSessionFileParser, which makes adding new plug-ins easier.

This originally was part of https://reviews.llvm.org/D89283

Differential Revision: https://reviews.llvm.org/D89408




More information about the All-commits mailing list