[all-commits] [llvm/llvm-project] 56f6bf: [AMDGPU] Remove MUL_LOHI_U24/MUL_LOHI_I24

Jay Foad via All-commits all-commits at lists.llvm.org
Mon Oct 19 11:20:46 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 56f6bf1a8d6c9288d54737479ba0bbe792528625
      https://github.com/llvm/llvm-project/commit/56f6bf1a8d6c9288d54737479ba0bbe792528625
  Author: Jay Foad <jay.foad at amd.com>
  Date:   2020-10-19 (Mon, 19 Oct 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUISelLowering.h

  Log Message:
  -----------
  [AMDGPU] Remove MUL_LOHI_U24/MUL_LOHI_I24

These were introduced in r279902 on the grounds that using separate
MUL_U24/MUL_I24 and MULHI_U24/MULHI_I24 nodes would introduce multiple
uses of the operands, which would prevent SimplifyDemandedBits from
simplifying the operands.

This has since been fixed by D24672 "AMDGPU/SI: Use new SimplifyDemandedBits helper for multi-use operations"

No functional change intended. At least it has no effect on lit tests.

Differential Revision: https://reviews.llvm.org/D89706




More information about the All-commits mailing list