[all-commits] [llvm/llvm-project] 46a119: [ASTImporter] Add Visitor for TypedefNameDecl's

[Balogh, Ádám via All-commits]

  Branch: refs/heads/ImmutableMapRefFix
  Home:   https://github.com/llvm/llvm-project
  Commit: 46a1198f805c65fe3f6b1170ad012819e158c1fe
      https://github.com/llvm/llvm-project/commit/46a1198f805c65fe3f6b1170ad012819e158c1fe
  Author: Vince Bridgers <vince.a.bridgers at gmail.com>
  Date:   2020-10-14 (Wed, 14 Oct 2020)

  Changed paths:
    M clang/lib/AST/ASTImporterLookupTable.cpp
    A clang/test/Analysis/Inputs/ctu-import.c
    A clang/test/Analysis/Inputs/ctu-import.c.externalDefMap.ast-dump.txt
    A clang/test/Analysis/ctu-implicit.c

  Log Message:
  -----------
  [ASTImporter] Add Visitor for TypedefNameDecl's

We found a case where Typedef Name Declarations were not being added
correctly when importing builtin types. This exposed the need for a
TypedefNameDecl visitor so these types can be added by RecordDecl and
fields.

This code is covered by the ASTImporterTest cases that use the implicit
struct __NSConstantString_tag definitions.

Thanks to @martong for the debugging assist!

Depends on D83970.

Reviewed By: martong

Differential Revision: https://reviews.llvm.org/D83992


  Commit: f1ca50a5094653463e350daa6c508885f61f11b4
      https://github.com/llvm/llvm-project/commit/f1ca50a5094653463e350daa6c508885f61f11b4
  Author: Gabor Marton <gabor.marton at ericsson.com>
  Date:   2020-10-14 (Wed, 14 Oct 2020)

  Changed paths:
    M clang/lib/AST/ASTStructuralEquivalence.cpp
    M clang/unittests/AST/StructuralEquivalenceTest.cpp

  Log Message:
  -----------
  D88665 id 295585 [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl


  Commit: c7203d1457dd206b48780d8e3a786b2c1b91b4f0
      https://github.com/llvm/llvm-project/commit/c7203d1457dd206b48780d8e3a786b2c1b91b4f0
  Author: Valeriy Savchenko <vsavchenko at apple.com>
  Date:   2020-10-14 (Wed, 14 Oct 2020)

  Changed paths:
    M clang/include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h
    M clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h
    M clang/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h
    M clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp
    M clang/lib/StaticAnalyzer/Core/ExprEngine.cpp
    M clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp
    M clang/lib/StaticAnalyzer/Core/SValBuilder.cpp
    M clang/lib/StaticAnalyzer/Core/SVals.cpp
    M clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp
    A clang/test/Analysis/PR46264.cpp
    M clang/test/Analysis/pointer-to-member.cpp

  Log Message:
  -----------
  [analyzer] Fix crash with pointer to members values

This fix unifies all of the different ways we handled pointer to
members into one.  The crash was caused by the fact that the type
of pointer-to-member values was `void *`, and while this works
for the vast majority of cases it breaks when we actually need
to explain the path for the report.

rdar://problem/64202361

Differential Revision: https://reviews.llvm.org/D85817


  Commit: 441e3967f06b896702692a0bc515da11f3e9d83a
      https://github.com/llvm/llvm-project/commit/441e3967f06b896702692a0bc515da11f3e9d83a
  Author: Adam Balogh <adam.balogh at ericsson.com>
  Date:   2020-10-16 (Fri, 16 Oct 2020)

  Changed paths:
    M llvm/include/llvm/ADT/ImmutableMap.h
    M llvm/unittests/ADT/ImmutableMapTest.cpp

  Log Message:
  -----------
  [ADT] Fix for ImmutableMapRef

The `Root` member of `ImmutableMapRef` was changed recently from a
plain pointer to `IntrusiveRefCntPtr`. However, the `Profile` member
function was not adjusted. This results in comilation error whenever
the `Profile` method is used on an `ImmutableMapRef`. This patch fixes
this issue and also adds unit tests for `ImmutableMapRef`. See bug
[[ https://bugs.llvm.org/show_bug.cgi?id=47863 | 47863 ]].

Differential Revision: https://reviews.llvm.org/D89486


Compare: https://github.com/llvm/llvm-project/compare/46a1198f805c%5E...441e3967f06b