[all-commits] [llvm/llvm-project] 609d76: [AArch64][GlobalISel] NFC: Refactor emitIntegerCom...

Jessica Paquette via All-commits all-commits at lists.llvm.org
Thu Oct 15 16:07:17 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 609d765cd3b1a4f9558b654dbb1bc7c973f3408b
      https://github.com/llvm/llvm-project/commit/609d765cd3b1a4f9558b654dbb1bc7c973f3408b
  Author: Jessica Paquette <jpaquette at apple.com>
  Date:   2020-10-15 (Thu, 15 Oct 2020)

  Changed paths:
    M llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp

  Log Message:
  -----------
  [AArch64][GlobalISel] NFC: Refactor emitIntegerCompare

Simplify emitIntegerCompare and improve comments + asserts.

Mostly making the code a little easier to follow.

Also, this code is only used for G_ICMP. The legalizer ensures that the LHS/RHS
for every G_ICMP is either a s32 or s64. So, there's no need to handle anything
else. This lets us remove a bunch of checks for whether or not we successfully
emitted the compare.

Differential Revision: https://reviews.llvm.org/D89433




More information about the All-commits mailing list