[all-commits] [llvm/llvm-project] 9c728a: [mlir] Fix typo in LangRef

Sean Silva via All-commits all-commits at lists.llvm.org
Thu Oct 15 12:20:59 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9c728a7cbf5df69627966b823d30daa6cfe2426d
      https://github.com/llvm/llvm-project/commit/9c728a7cbf5df69627966b823d30daa6cfe2426d
  Author: Sean Silva <silvasean at google.com>
  Date:   2020-10-15 (Thu, 15 Oct 2020)

  Changed paths:
    M mlir/docs/LangRef.md

  Log Message:
  -----------
  [mlir] Fix typo in LangRef


  Commit: ee491ac91e123b90eeec3cce7e494936ea8cb85d
      https://github.com/llvm/llvm-project/commit/ee491ac91e123b90eeec3cce7e494936ea8cb85d
  Author: Sean Silva <silvasean at google.com>
  Date:   2020-10-15 (Thu, 15 Oct 2020)

  Changed paths:
    M mlir/include/mlir/Dialect/StandardOps/IR/Ops.td
    M mlir/include/mlir/Dialect/StandardOps/Transforms/Passes.h
    M mlir/include/mlir/Dialect/StandardOps/Transforms/Passes.td
    M mlir/include/mlir/Transforms/Bufferize.h
    M mlir/lib/Dialect/StandardOps/IR/Ops.cpp
    A mlir/lib/Dialect/StandardOps/Transforms/Bufferize.cpp
    M mlir/lib/Dialect/StandardOps/Transforms/CMakeLists.txt
    M mlir/lib/Transforms/Bufferize.cpp
    A mlir/test/Dialect/Standard/bufferize.mlir
    A mlir/test/Dialect/Standard/canonicalize.mlir
    M mlir/test/Dialect/Standard/ops.mlir

  Log Message:
  -----------
  [mlir] Add std.tensor_to_memref op and teach the infra about it

The opposite of tensor_to_memref is tensor_load.

- Add some basic tensor_load/tensor_to_memref folding.
- Add source/target materializations to BufferizeTypeConverter.
- Add an example std bufferization pattern/pass that shows how the
  materialiations work together (more std bufferization patterns to come
  in subsequent commits).
  - In coming commits, I'll document how to write composable
  bufferization passes/patterns and update the other in-tree
  bufferization passes to match this convention. The populate* functions
  will of course continue to be exposed for power users.

The naming on tensor_load/tensor_to_memref and their pretty forms are
not very intuitive. I'm open to any suggestions here. One key
observation is that the memref type must always be the one specified in
the pretty form, since the tensor type can be inferred from the memref
type but not vice-versa.

With this, I've been able to replace all my custom bufferization type
converters in npcomp with BufferizeTypeConverter!

Part of the plan discussed in:
https://llvm.discourse.group/t/what-is-the-strategy-for-tensor-memref-conversion-bufferization/1938/17

Differential Revision: https://reviews.llvm.org/D89437


Compare: https://github.com/llvm/llvm-project/compare/3785a413feef...ee491ac91e12


More information about the All-commits mailing list