[all-commits] [llvm/llvm-project] 32a4ad: [LLD] Set alignment as part of Characteristics in ...

[Luqman Aden via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 32a4ad3b6ce6028a371b028cf06fa5feff9534bf
      https://github.com/llvm/llvm-project/commit/32a4ad3b6ce6028a371b028cf06fa5feff9534bf
  Author: Luqman Aden <me at luqman.ca>
  Date:   2020-10-14 (Wed, 14 Oct 2020)

  Changed paths:
    M lld/COFF/Writer.cpp

  Log Message:
  -----------
  [LLD] Set alignment as part of Characteristics in TLS table.

Fixes https://bugs.llvm.org/show_bug.cgi?id=46473

LLD wasn't previously specifying any specific alignment in the TLS table's Characteristics field so the loader would just assume the default value (16 bytes). This works most of the time except if you have thread locals that want specific higher alignments (e.g. 32 as in the bug) *even* if they specify an alignment on the thread local. This change updates LLD to take the max alignment from tls section.

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D88637