[all-commits] [llvm/llvm-project] 42e89a: [flang] Fix CMake bug in the definition of flang-new
Andrzej WarzyĆski via All-commits
all-commits at lists.llvm.org
Wed Oct 14 11:25:20 PDT 2020
Branch: refs/heads/master
Home: https://github.com/llvm/llvm-project
Commit: 42e89ab2a668c80449a13210f07a50fe0370e99d
https://github.com/llvm/llvm-project/commit/42e89ab2a668c80449a13210f07a50fe0370e99d
Author: Andrzej Warzynski <andrzej.warzynski at arm.com>
Date: 2020-10-14 (Wed, 14 Oct 2020)
Changed paths:
M flang/CMakeLists.txt
M flang/tools/flang-driver/CMakeLists.txt
Log Message:
-----------
[flang] Fix CMake bug in the definition of flang-new
Recent patch that improved Flang's compatibility with respect to how LLVM
dynamic libraries should be linked (and specified in CMake recipes),
introduced a bug in the definition of `flang-new`:
* https://reviews.llvm.org/D87893
More specifically, `add_flang_tool` does not support the
`LINK_COMPONENTS` CMake argument. Instead, one should set
`LLVM_LINK_COMPONENTS` before calling `add_flang_tool`.
This patch reverts the change for `flang-new` from
https://reviews.llvm.org/D87893, and instead:
* sets `LLVM_LINK_COMPONENTS`
* calls `clang_target_link_libraries` to add Clang dependencies
Differential Revision: https://reviews.llvm.org/D89403
More information about the All-commits
mailing list