[all-commits] [llvm/llvm-project] 60ba92: Revert rG25a97c3a43d7 - "[InstCombine] visitCallIn...

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Wed Oct 14 10:20:29 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 60ba9233d126f828bd4f79f02bc8e2330fead566
      https://github.com/llvm/llvm-project/commit/60ba9233d126f828bd4f79f02bc8e2330fead566
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-10-14 (Wed, 14 Oct 2020)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp
    M llvm/test/Transforms/InstCombine/funnel.ll
    M llvm/test/Transforms/InstCombine/rotate.ll

  Log Message:
  -----------
  Revert rG25a97c3a43d7 - "[InstCombine] visitCallInst - retain undefs in vector funnel shift amounts"

This reverts commit 25a97c3a43d7bc469ec67dd4e901a507b9b11116.

We have other constant folds that fold undef funnel shift amounts to 0 - so we need to be consistent.

If we end up with regressions where we lose a splat shift amount pattern we'll have to investigate other canonicalizations, but matchFunnelShift currently protects us from that.




More information about the All-commits mailing list