[all-commits] [llvm/llvm-project] 41d85f: [libc++] Remove signal-based checkpoints in libc++...

[Louis Dionne via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 41d85fe0e168bf1e846e582a95f82ff8ecaf7c28
      https://github.com/llvm/llvm-project/commit/41d85fe0e168bf1e846e582a95f82ff8ecaf7c28
  Author: Louis Dionne <ldionne at apple.com>
  Date:   2020-10-14 (Wed, 14 Oct 2020)

  Changed paths:
    M libcxx/test/libcxx/debug/containers/db_sequence_container_iterators.pass.cpp
    M libcxx/test/libcxx/debug/containers/db_string.pass.cpp
    M libcxx/test/std/containers/map_allocator_requirement_test_templates.h
    M libcxx/test/std/containers/set_allocator_requirement_test_templates.h
    M libcxx/test/std/input.output/filesystems/class.path/path.member/path.decompose/path.decompose.pass.cpp
    M libcxx/test/std/input.output/filesystems/class.path/path.member/path.modifiers/replace_filename.pass.cpp
    R libcxx/test/support/assert_checkpoint.h
    M libcxx/test/support/container_debug_tests.h
    M libcxx/test/support/debug_mode_helper.h

  Log Message:
  -----------
  [libc++] Remove signal-based checkpoints in libc++ tests

While this adds some convenience to the test suite, it prevents the tests
using these checkpoints from being used on systems where signals are not
available, such as some embedded systems. It will also prevent these tests
from being constexpr-friendly once e.g. std::map is made constexpr, due
to the use of statics.

Instead, one can always use a debugger to figure out exactly where a
test is failing when that isn't clear from the log output without
checkpoints.