[all-commits] [llvm/llvm-project] 24c166: [cmake] Unconditionally set the force flag when co...

Vedant Kumar via All-commits all-commits at lists.llvm.org
Tue Oct 13 16:51:27 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 24c1660ac5d7813072b429eee7a9531338e53aea
      https://github.com/llvm/llvm-project/commit/24c1660ac5d7813072b429eee7a9531338e53aea
  Author: Vedant Kumar <vsk at apple.com>
  Date:   2020-10-13 (Tue, 13 Oct 2020)

  Changed paths:
    M llvm/cmake/modules/AddLLVM.cmake

  Log Message:
  -----------
  [cmake] Unconditionally set the force flag when codesigning

The Darwin linker now defaults to ad hoc signing binaries when targeting
Apple Silicon. This creates a problem when configuring targets that must
be built with entitlements: we either need to add -Wl,-no_adhoc_codesign
when building the target, or sign with the force flag set to allow
replacing a pre-existing signature.

Unconditionally force-signing is the more convenient solution. This
doesn't require a ld64 version check, and it's a much less invasive
cmake change.

Patch by Fred Riss!

rdar://70237254

Differential Revision: https://reviews.llvm.org/D89343




More information about the All-commits mailing list