[all-commits] [llvm/llvm-project] b98e5e: [mlir] Move Linalg tensors-to-buffers tests to Lin...

Alexander Belyaev via All-commits all-commits at lists.llvm.org
Mon Oct 12 01:19:49 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: b98e5e0f7e99d6b72aa637cc00790b98021e2086
      https://github.com/llvm/llvm-project/commit/b98e5e0f7e99d6b72aa637cc00790b98021e2086
  Author: Alexander Belyaev <pifon at google.com>
  Date:   2020-10-12 (Mon, 12 Oct 2020)

  Changed paths:
    M mlir/lib/Dialect/Linalg/Transforms/TensorsToBuffers.cpp
    M mlir/test/Dialect/Linalg/tensors-to-buffers.mlir
    M mlir/test/Transforms/buffer-placement-preparation.mlir

  Log Message:
  -----------
  [mlir] Move Linalg tensors-to-buffers tests to Linalg tests.

The buffer placement preparation tests in
test/Transforms/buffer-placement-preparation* are using Linalg as a test
dialect which leads to confusion and "copy-pasta", i.e. Linalg is being
extended now and when TensorsToBuffers.cpp is changed, TestBufferPlacement is
sometimes kept in-sync, which should not be the case.

This has led to the unnoticed bug, because the tests were in a different directory and the patterns were slightly off.

Differential Revision: https://reviews.llvm.org/D89209




More information about the All-commits mailing list