[all-commits] [llvm/llvm-project] 0610a2: [lldb] Delete copy operations on PluginInterface c...

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0610a25a85a0a204c994331e1ab275f86010f9ad
      https://github.com/llvm/llvm-project/commit/0610a25a85a0a204c994331e1ab275f86010f9ad
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-10-09 (Fri, 09 Oct 2020)

  Changed paths:
    M lldb/include/lldb/Core/Architecture.h
    M lldb/include/lldb/Core/PluginInterface.h
    M lldb/include/lldb/Symbol/SymbolVendor.h
    M lldb/include/lldb/Target/DynamicLoader.h
    M lldb/include/lldb/Target/LanguageRuntime.h
    M lldb/include/lldb/Target/OperatingSystem.h
    M lldb/include/lldb/Target/Platform.h
    M lldb/include/lldb/Target/UnwindAssembly.h
    M lldb/source/Core/DynamicLoader.cpp
    M lldb/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.h
    M lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.h
    M lldb/source/Plugins/DynamicLoader/Static/DynamicLoaderStatic.cpp
    M lldb/source/Plugins/DynamicLoader/Static/DynamicLoaderStatic.h
    M lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp
    M lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.h
    M lldb/source/Plugins/Platform/Android/PlatformAndroid.cpp
    M lldb/source/Plugins/Platform/Android/PlatformAndroid.h
    M lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp
    M lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.h
    M lldb/source/Plugins/Platform/Linux/PlatformLinux.cpp
    M lldb/source/Plugins/Platform/Linux/PlatformLinux.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp
    M lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformRemoteAppleBridge.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformRemoteAppleTV.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformRemoteAppleWatch.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformRemoteiOS.h
    M lldb/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
    M lldb/source/Plugins/Platform/NetBSD/PlatformNetBSD.h
    M lldb/source/Plugins/Platform/OpenBSD/PlatformOpenBSD.cpp
    M lldb/source/Plugins/Platform/OpenBSD/PlatformOpenBSD.h
    M lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp
    M lldb/source/Plugins/Platform/Windows/PlatformWindows.h
    M lldb/source/Plugins/Process/elf-core/ProcessElfCore.h
    M lldb/source/Plugins/Process/mach-core/ProcessMachCore.h
    M lldb/source/Plugins/SymbolFile/Symtab/SymbolFileSymtab.cpp
    M lldb/source/Plugins/SymbolFile/Symtab/SymbolFileSymtab.h
    M lldb/source/Plugins/SymbolVendor/ELF/SymbolVendorELF.cpp
    M lldb/source/Plugins/SymbolVendor/ELF/SymbolVendorELF.h
    M lldb/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp
    M lldb/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.h
    M lldb/source/Plugins/SymbolVendor/wasm/SymbolVendorWasm.h
    M lldb/source/Symbol/SymbolVendor.cpp
    M lldb/source/Target/LanguageRuntime.cpp
    M lldb/source/Target/OperatingSystem.cpp
    M lldb/source/Target/UnwindAssembly.cpp

  Log Message:
  -----------
  [lldb] Delete copy operations on PluginInterface class

This is a polymorphic class, copying it is a bad idea.

This was not a problem because most classes inheriting from it were
deleting their copy operations themselves. However, this enables us to
delete those explicit deletions, and ensure noone forgets to add them in
the future.