[all-commits] [llvm/llvm-project] 5367a8: Revert "[MLIR] Add a foldTrait() mechanism to allo...

[Mehdi Amini via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5367a8b67fa18bc26635c69bd138596436b3fc28
      https://github.com/llvm/llvm-project/commit/5367a8b67fa18bc26635c69bd138596436b3fc28
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2020-10-09 (Fri, 09 Oct 2020)

  Changed paths:
    M mlir/docs/Traits.md
    M mlir/include/mlir/IR/OpBase.td
    M mlir/include/mlir/IR/OpDefinition.h
    M mlir/lib/IR/Operation.cpp
    M mlir/test/lib/Dialect/Test/CMakeLists.txt
    M mlir/test/lib/Dialect/Test/TestOps.td
    R mlir/test/lib/Dialect/Test/TestTraits.cpp
    R mlir/test/mlir-tblgen/trait.mlir
    M mlir/tools/mlir-opt/mlir-opt.cpp

  Log Message:
  -----------
  Revert "[MLIR] Add a foldTrait() mechanism to allow traits to define folding and test it with an Involution trait"

This reverts commit 1ceaffd95a6bdc4b7d2193e049bcd6b40ee9ff50.

The build is broken with  -DBUILD_SHARED_LIBS=ON ; seems like a possible
layering issue to investigate:

tools/mlir/lib/IR/CMakeFiles/obj.MLIRIR.dir/Operation.cpp.o: In function `mlir::MemoryEffectOpInterface::hasNoEffect(mlir::Operation*)':
Operation.cpp:(.text._ZN4mlir23MemoryEffectOpInterface11hasNoEffectEPNS_9OperationE[_ZN4mlir23MemoryEffectOpInterface11hasNoEffectEPNS_9OperationE]+0x9c): undefined reference to `mlir::MemoryEffectOpInterface::getEffects(llvm::SmallVectorImpl<mlir::SideEffects::EffectInstance<mlir::MemoryEffects::Effect> >&)'


  Commit: 16580d791f3bf4fba8164054a04e4f85a1bd299b
      https://github.com/llvm/llvm-project/commit/16580d791f3bf4fba8164054a04e4f85a1bd299b
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2020-10-09 (Fri, 09 Oct 2020)

  Changed paths:
    M flang/include/flang/Optimizer/CodeGen/CMakeLists.txt
    M flang/include/flang/Optimizer/Transforms/CMakeLists.txt

  Log Message:
  -----------
  Remove -gen-pass-doc from Flang CMake configuration: the documentation generation is broken

`ninja mlir-doc` fails when Flang is configured with this.


Compare: https://github.com/llvm/llvm-project/compare/0a34492f36d7...16580d791f3b