[all-commits] [llvm/llvm-project] be6698: Fix raciness in the StopHook check for "has the ta...

[jimingham via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: be66987e2047636d9ed9d2a4d88b762d59ae88f2
      https://github.com/llvm/llvm-project/commit/be66987e2047636d9ed9d2a4d88b762d59ae88f2
  Author: Jim Ingham <jingham at apple.com>
  Date:   2020-10-05 (Mon, 05 Oct 2020)

  Changed paths:
    M lldb/include/lldb/Target/Target.h
    M lldb/source/Target/Process.cpp
    M lldb/source/Target/Target.cpp
    M lldb/test/API/commands/target/stop-hooks/TestStopHookScripted.py

  Log Message:
  -----------
  Fix raciness in the StopHook check for "has the target run".

This was looking at the privateState, but it's possible that
the actual process has started up and then stopped again by the
time we get to the check, which would lead us to get out of running
the stop hooks too early.

Instead we need to track the intention of the stop hooks directly.

Differential Revision: https://reviews.llvm.org/D88753