[all-commits] [llvm/llvm-project] 4600e2: [AArch64][SVE] Drop "argmemonly" from gather/scatt...

Craig Disselkoen via All-commits all-commits at lists.llvm.org
Fri Sep 25 16:01:36 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 4600e210514281d2ac049e1c46d3f10bd17bf25c
      https://github.com/llvm/llvm-project/commit/4600e210514281d2ac049e1c46d3f10bd17bf25c
  Author: Eli Friedman <efriedma at quicinc.com>
  Date:   2020-09-25 (Fri, 25 Sep 2020)

  Changed paths:
    M llvm/include/llvm/IR/IntrinsicsAArch64.td
    M llvm/test/Transforms/LICM/AArch64/sve-load-hoist.ll

  Log Message:
  -----------
  [AArch64][SVE] Drop "argmemonly" from gather/scatter with vector base.

The intrinsics don't have any pointer arguments, so "argmemonly" makes
optimizations think they don't write to memory at all.

Differential Revision: https://reviews.llvm.org/D88186


  Commit: 48961ba0de3c556b092d434bd86583401495f101
      https://github.com/llvm/llvm-project/commit/48961ba0de3c556b092d434bd86583401495f101
  Author: Layton Kifer <laytonkifer at gmail.com>
  Date:   2020-09-25 (Fri, 25 Sep 2020)

  Changed paths:
    M llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp

  Log Message:
  -----------
  [TRE][NFC] Refactor Basic Block Processing

Simplify and improve readability.

Differential Revision: https://reviews.llvm.org/D82269


  Commit: 51cad041e0cb26597c7ccc0fbfaa349b8fffbcda
      https://github.com/llvm/llvm-project/commit/51cad041e0cb26597c7ccc0fbfaa349b8fffbcda
  Author: Craig Disselkoen <craigdissel at gmail.com>
  Date:   2020-09-25 (Fri, 25 Sep 2020)

  Changed paths:
    M llvm/include/llvm-c/Core.h
    M llvm/lib/IR/Core.cpp
    M llvm/test/Bindings/llvm-c/echo.ll
    M llvm/tools/llvm-c-test/echo.cpp
    M llvm/tools/llvm-c-test/main.c

  Log Message:
  -----------
  C API: functions to get mask of a ShuffleVector

This commit fixes a regression (from LLVM 10 to LLVM 11 RC3) in the LLVM
C API.

Previously, commit 1ee6ec2bf removed the mask operand from the
ShuffleVector instruction, storing the mask data separately in the
instruction instead; this reduced the number of operands of
ShuffleVector from 3 to 2. AFAICT, this change unintentionally caused
a regression in the LLVM C API. Specifically, it is no longer possible
to get the mask of a ShuffleVector instruction through the C API. This
patch introduces new functions which together allow a C API user to get
the mask of a ShuffleVector instruction, restoring the functionality
which was previously available through LLVMGetOperand().

This patch also adds tests for this change to the llvm-c-test
executable, which involved adding support for InsertElement,
ExtractElement, and ShuffleVector itself (as well as constant vectors)
to echo.cpp. Previously, vector operations weren't tested at all in
echo.ll.

I also fixed some typos in comments and help-text nearby these changes,
which I happened to spot while developing this patch. Since the typo
fixes are technically unrelated other than being in the same files, I'm
happy to take them out if you'd rather they not be included in the patch.

Differential Revision: https://reviews.llvm.org/D88190


Compare: https://github.com/llvm/llvm-project/compare/b65966cff65b...51cad041e0cb


More information about the All-commits mailing list