[all-commits] [llvm/llvm-project] 15d94a: Revert "Canonicalize declaration pointers when for...

[Leonard Chan via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 15d94a7d0f8f0d6b3b5308fff51b286957e45650
      https://github.com/llvm/llvm-project/commit/15d94a7d0f8f0d6b3b5308fff51b286957e45650
  Author: Leonard Chan <leonardchan at google.com>
  Date:   2020-09-22 (Tue, 22 Sep 2020)

  Changed paths:
    M clang/include/clang/AST/APValue.h
    M clang/lib/AST/APValue.cpp
    M clang/lib/AST/Decl.cpp
    M clang/lib/AST/DeclBase.cpp
    M clang/lib/AST/ExprConstant.cpp
    M clang/test/CXX/dcl.dcl/dcl.spec/dcl.constexpr/p9.cpp
    M clang/test/OpenMP/ordered_messages.cpp

  Log Message:
  -----------
  Revert "Canonicalize declaration pointers when forming APValues."

This reverts commit 905b9ca26c94fa86339451a528cedde5004fc1bb.

Reverting because this strips `weak` attributes off function
declarations, leading to the linker error we see at
https://ci.chromium.org/p/fuchsia/builders/ci/clang_toolchain.fuchsia-arm64-debug-subbuild/b8868932035091473008.

See https://reviews.llvm.org/rG905b9ca26c94 for reproducer details.