[all-commits] [llvm/llvm-project] a6f8ae: [test][MC] Rehabilitate llvm/test/MC/COFF/bigobj.py

Hubert Tong via All-commits all-commits at lists.llvm.org
Tue Sep 22 11:23:53 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a6f8aeb51c731ce01b995725cbda3f9be9059ab0
      https://github.com/llvm/llvm-project/commit/a6f8aeb51c731ce01b995725cbda3f9be9059ab0
  Author: Hubert Tong <hubert.reinterpretcast at gmail.com>
  Date:   2020-09-22 (Tue, 22 Sep 2020)

  Changed paths:
    M llvm/test/MC/COFF/bigobj.py
    M llvm/test/MC/COFF/lit.local.cfg

  Log Message:
  -----------
  [test][MC] Rehabilitate llvm/test/MC/COFF/bigobj.py

The subject test was not actually running. This patch adds the
relevant suffix to the list of lit case filename extensions for the
enclosing directory.

Minor adjustments are also made to deal with bit rot.

Reviewed By: daltenty

Differential Revision: https://reviews.llvm.org/D87122


  Commit: b0f58aa116a1ac2c2fa6b1667017bb29b3418411
      https://github.com/llvm/llvm-project/commit/b0f58aa116a1ac2c2fa6b1667017bb29b3418411
  Author: Hubert Tong <hubert.reinterpretcast at gmail.com>
  Date:   2020-09-22 (Tue, 22 Sep 2020)

  Changed paths:
    M llvm/lib/Target/PowerPC/PPCInstrPrefix.td

  Log Message:
  -----------
  [NFC] Replace tabs with spaces in PPCInstrPrefix.td


  Commit: 6801950192ff4f6d60c822fc721354f34e609e7a
      https://github.com/llvm/llvm-project/commit/6801950192ff4f6d60c822fc721354f34e609e7a
  Author: Hubert Tong <hubert.reinterpretcast at gmail.com>
  Date:   2020-09-22 (Tue, 22 Sep 2020)

  Changed paths:
    M llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp
    M llvm/test/Transforms/InstCombine/pow-4.ll

  Log Message:
  -----------
  [InstCombine] For pow(x, +/-0.5), stop falling into pow(x, 1.5), etc. case

The current code for handling pow(x, y) where y is an integer plus 0.5
is not explicitly guarded against attempting to transform the case where
abs(y) is exactly 0.5.

The latter case is meant to be handled by `replacePowWithSqrt`. Indeed,
if the pow(x, integer+0.5) case proceeds past a certain point, it will
hit an assertion by attempting to form pow(x, 0) using `getPow`.

This patch adds an explicit check to prevent attempting the
pow(x, integer+0.5) transformation on pow(x, +/-0.5) as suggested during
the review of D87877. This has the effect of retaining the shrinking of
`pow` to `powf` when the `sqrt` libcall cannot be formed.

Reviewed By: spatel

Differential Revision: https://reviews.llvm.org/D88066


Compare: https://github.com/llvm/llvm-project/compare/16ca71180330...6801950192ff


More information about the All-commits mailing list