[all-commits] [llvm/llvm-project] 410b0d: [llvm] Add contains(KeyType) -> bool methods to Sm...

James Y Knight via All-commits all-commits at lists.llvm.org
Tue Sep 22 02:43:42 PDT 2020


  Branch: refs/heads/release/11.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 410b0dc84bbdafabe3a2c3eedd96e50340a6e0d0
      https://github.com/llvm/llvm-project/commit/410b0dc84bbdafabe3a2c3eedd96e50340a6e0d0
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2020-09-22 (Tue, 22 Sep 2020)

  Changed paths:
    M llvm/include/llvm/ADT/SmallPtrSet.h
    M llvm/unittests/ADT/SmallPtrSetTest.cpp

  Log Message:
  -----------
  [llvm] Add contains(KeyType) -> bool methods to SmallPtrSet

Matches C++20 API addition.

Differential Revision: https://reviews.llvm.org/D83449

(cherry picked from commit a0385bd7acd6e1d16224b4257f4cb50e59f1d75e)


  Commit: 6250d4944539f67d6a605928e97c087fe306a79e
      https://github.com/llvm/llvm-project/commit/6250d4944539f67d6a605928e97c087fe306a79e
  Author: James Y Knight <jyknight at google.com>
  Date:   2020-09-22 (Tue, 22 Sep 2020)

  Changed paths:
    M llvm/lib/CodeGen/PHIEliminationUtils.cpp
    A llvm/test/CodeGen/X86/callbr-asm-phi-placement.ll

  Log Message:
  -----------
  PR47468: Fix findPHICopyInsertPoint, so that copies aren't incorrectly inserted after an INLINEASM_BR.

findPHICopyInsertPoint special cases placement in a block with a
callbr or invoke in it. In that case, we must ensure that the copy is
placed before the INLINEASM_BR or call instruction, if the register is
defined prior to that instruction, because it may jump out of the
block.

Previously, the code placed it immediately after the last def _or
use_. This is wrong, if the use is the instruction which may jump.  We
could correctly place it immediately after the last def (ignoring
uses), but that is non-optimal for register pressure.

Instead, place the copy after the last def, or before the
call/inlineasm_br, whichever is later.

Differential Revision: https://reviews.llvm.org/D87865

(cherry picked from commit f7a53d82c0902147909f28a9295a9d00b4b27d38)


Compare: https://github.com/llvm/llvm-project/compare/b78e5de029c2...6250d4944539


More information about the All-commits mailing list