[all-commits] [llvm/llvm-project] 28b84d: [llvm-readobj/elf] - Stop reporting invalid extend...

Georgii Rymar via All-commits all-commits at lists.llvm.org
Tue Sep 22 02:03:24 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 28b84dd138666abc005de4810af16bcf007530ea
      https://github.com/llvm/llvm-project/commit/28b84dd138666abc005de4810af16bcf007530ea
  Author: Georgii Rymar <grimar at accesssoftek.com>
  Date:   2020-09-22 (Tue, 22 Sep 2020)

  Changed paths:
    M llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test
    M llvm/tools/llvm-readobj/ELFDumper.cpp

  Log Message:
  -----------
  [llvm-readobj/elf] - Stop reporting invalid extended indexes in warnings for unnamed section symbols.

We have an issue with `getFullSymbolName`: it assumes that the symbol passed is
always in the `.symtab`, what is wrong. We might calculate and report a wrong index currently.
I've added a test case revealing that.

This patch adds the "symbol index" argument to `getFullSymbolName` signature,
what fixes the issue.

Differential revision: https://reviews.llvm.org/D87899




More information about the All-commits mailing list