[all-commits] [llvm/llvm-project] 6807f2: [ASTImporter] Modifying ImportDeclContext(...) to ...

[Shafik Yaghmour via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6807f244fa67bb75ef09fb3db54743b5b358a7fa
      https://github.com/llvm/llvm-project/commit/6807f244fa67bb75ef09fb3db54743b5b358a7fa
  Author: shafik <syaghmour at apple.com>
  Date:   2020-09-21 (Mon, 21 Sep 2020)

  Changed paths:
    M clang/lib/AST/ASTImporter.cpp
    A lldb/test/API/commands/expression/codegen-crash-import-def-arraytype-element/Makefile
    A lldb/test/API/commands/expression/codegen-crash-import-def-arraytype-element/TestImportDefinitionArrayType.py
    A lldb/test/API/commands/expression/codegen-crash-import-def-arraytype-element/main.cpp

  Log Message:
  -----------
  [ASTImporter] Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl

When we fixed ImportDeclContext(...) in D71378 to make sure we complete each
FieldDecl of a RecordDecl when we are importing the definition we missed the
case where a FeildDecl was an ArrayType whose ElementType is a record.

This fix was motivated by a codegen crash during LLDB expression parsing. Since
we were not importing the definition we were crashing during layout which
required all the records be defined.

Differential Revision: https://reviews.llvm.org/D86660