[all-commits] [llvm/llvm-project] 4eae6f: [clang] Fix incorrect call to TextDiagnostic::prin...

Andrzej WarzyƄski via All-commits all-commits at lists.llvm.org
Mon Sep 21 01:42:49 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 4eae6fc95f95563a73a510a8b09cfce01004930a
      https://github.com/llvm/llvm-project/commit/4eae6fc95f95563a73a510a8b09cfce01004930a
  Author: Andrzej Warzynski <andrzej.warzynski at arm.com>
  Date:   2020-09-21 (Mon, 21 Sep 2020)

  Changed paths:
    M clang/lib/Frontend/TextDiagnosticPrinter.cpp

  Log Message:
  -----------
  [clang] Fix incorrect call to TextDiagnostic::printDiagnosticMessage

As per the documentation, the 2nd argument in printDiagnosticMessage
should be a bool that specifies whether the underlying message is a
continuation note diagnostic or not. More specifically, it should be:
```
Level == DiagnosticsEngine::Note
```
instead of:
```
Level
```

This change means that `no input file` in the following scenario will be
now correctly printed in bold:
```
$ bin/clang
clang: error: no input files
```
In terminals that don't support text formatting the behaviour doesn't
change.

Differential Revision: https://reviews.llvm.org/D87816




More information about the All-commits mailing list