[all-commits] [llvm/llvm-project] a0017c: [MemorySSA] Be more conservative when traversing M...

Florian Hahn via All-commits all-commits at lists.llvm.org
Thu Sep 17 14:21:57 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a0017c2bc258690146f18491317144e487ddb101
      https://github.com/llvm/llvm-project/commit/a0017c2bc258690146f18491317144e487ddb101
  Author: Florian Hahn <flo at fhahn.com>
  Date:   2020-09-17 (Thu, 17 Sep 2020)

  Changed paths:
    M llvm/include/llvm/Analysis/MemorySSA.h
    M llvm/test/Analysis/MemorySSA/phi-translation.ll

  Log Message:
  -----------
  [MemorySSA] Be more conservative when traversing MemoryPhis.

I think we need to be even more conservative when traversing memory
phis, to make sure we catch any loop carried dependences.

This approach updates fillInCurrentPair to use unknown sizes for
locations when we walk over a phi, unless the location is guaranteed to
be loop-invariant for any possible loop. Using an unknown size for
locations should ensure we catch all memory accesses to locations after
the given memory location, which includes loop-carried dependences.

Reviewed By: asbirlea

Differential Revision: https://reviews.llvm.org/D87778




More information about the All-commits mailing list