[all-commits] [llvm/llvm-project] dd6758: [lldb/test] Enable faulthandler in dotest

Jordan Rupprecht via All-commits all-commits at lists.llvm.org
Wed Sep 16 14:31:20 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: dd67581407c1693e43ac8a90b3a20c597614bda8
      https://github.com/llvm/llvm-project/commit/dd67581407c1693e43ac8a90b3a20c597614bda8
  Author: Jordan Rupprecht <rupprecht at google.com>
  Date:   2020-09-16 (Wed, 16 Sep 2020)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/dotest.py

  Log Message:
  -----------
  [lldb/test] Enable faulthandler in dotest

Register the `faulthandler` module so we can see what lldb tests are doing when they misbehave (e.g. run under a test runner that sets a timeout). This will print a stack trace for the following signals:

- `SIGSEGV`, `SIGFPE`, `SIGABRT`, `SIGBUS`, and `SIGILL` (via `faulthandler.enable()`)
- `SIGTERM` (via `faulthandler.register(SIGTERM)`) [This is what our test runners sends when it times out].

The only signal we currently handle is `SIGINT` (via `unittest2.signals.installHandler()`) so there should be no overlap added by this patch.

Because this import is not available until python3, and the `register()` method is not available on Windows, this is enabled defensively.

This should have absolutely no effect when tests are passing (or even normally failing), but can be observed by running this while ninja is running:

```
kill -s SIGTERM $(ps aux | grep dotest.py | head -1 | awk '{print $2}')
```

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D87637




More information about the All-commits mailing list