[all-commits] [llvm/llvm-project] a8d020: [llvm-readobj][test] - Improve section-symbols.test

Georgii Rymar via All-commits all-commits at lists.llvm.org
Wed Sep 16 02:36:46 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a8d02015fcb783d5fdf1e09edd1b9e152c5d19b7
      https://github.com/llvm/llvm-project/commit/a8d02015fcb783d5fdf1e09edd1b9e152c5d19b7
  Author: Georgii Rymar <grimar at accesssoftek.com>
  Date:   2020-09-16 (Wed, 16 Sep 2020)

  Changed paths:
    M llvm/test/tools/llvm-readobj/ELF/section-symbols.test

  Log Message:
  -----------
  [llvm-readobj][test] - Improve section-symbols.test

`section-symbols.test` tests how we print section symbols in
different situations.

We might have 2 different cases:
1) A named STT_SECTION symbol.
2) An unnamed STT_SECTION symbol.

Usually section symbols have no name and then `--symbols` uses their
section names when prints them. If symbol has a name, then it is used.

For `--relocations` we also want to have this logic probably,
but currently we always ignore symbol names and always use section names.
It is not consistent with GNU readelf and with our logic for `--symbols`.

This patch refines testing to document the existent behavior and improve
coverage.

Differential revision: https://reviews.llvm.org/D87612




More information about the All-commits mailing list