[all-commits] [llvm/llvm-project] 794467: [llvm-rc] Allow omitting components from VERSIONIN...

[Martin Storsjö via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 794467b916e87e8fb09380c67d0d433a29d93a2f
      https://github.com/llvm/llvm-project/commit/794467b916e87e8fb09380c67d0d433a29d93a2f
  Author: Martin Storsjö <martin at martin.st>
  Date:   2020-09-16 (Wed, 16 Sep 2020)

  Changed paths:
    M llvm/test/tools/llvm-rc/Inputs/tag-versioninfo.rc
    M llvm/test/tools/llvm-rc/tag-versioninfo.test
    M llvm/tools/llvm-rc/ResourceScriptParser.cpp

  Log Message:
  -----------
  [llvm-rc] Allow omitting components from VERSIONINFO versions

MS rc.exe doesn't require specifying all 4 components.

Differential Revision: https://reviews.llvm.org/D87570


  Commit: 74d7356fc63bd1f42bbb20b793f21decf3c98a6e
      https://github.com/llvm/llvm-project/commit/74d7356fc63bd1f42bbb20b793f21decf3c98a6e
  Author: Martin Storsjö <martin at martin.st>
  Date:   2020-09-16 (Wed, 16 Sep 2020)

  Changed paths:
    M llvm/tools/llvm-rc/ResourceFileWriter.cpp

  Log Message:
  -----------
  [llvm-rc] Update a comment. NFC.

Fix a typo and mention one missing step.


  Commit: c913f6dce69513b430f705d5a1f4e745f5d0a27e
      https://github.com/llvm/llvm-project/commit/c913f6dce69513b430f705d5a1f4e745f5d0a27e
  Author: Martin Storsjö <martin at martin.st>
  Date:   2020-09-16 (Wed, 16 Sep 2020)

  Changed paths:
    M llvm/tools/llvm-rc/Opts.td
    M llvm/tools/llvm-rc/llvm-rc.cpp

  Log Message:
  -----------
  [llvm-rc] Lowercase the option definitions. NFC.

This matches how such options are most commonly defined in other tools.

This was pointed out in an earlier review a few months ago, that
the llvm-rc td entries felt shouty.

The INCLUDE option is renamed to includepath, to avoid clashing with
the tablegen include directive.


Compare: https://github.com/llvm/llvm-project/compare/fc8200633122...c913f6dce695