[all-commits] [llvm/llvm-project] e62452: Revert "Double check that passes correctly set the...

[Hans via All-commits]

  Branch: refs/heads/release/11.x
  Home:   https://github.com/llvm/llvm-project
  Commit: e62452bb3e1e163daf75914cdf2e86deb4debf50
      https://github.com/llvm/llvm-project/commit/e62452bb3e1e163daf75914cdf2e86deb4debf50
  Author: Hans Wennborg <hans at chromium.org>
  Date:   2020-09-15 (Tue, 15 Sep 2020)

  Changed paths:
    M llvm/lib/IR/LegacyPassManager.cpp
    M llvm/unittests/IR/LegacyPassManagerTest.cpp

  Log Message:
  -----------
  Revert "Double check that passes correctly set their Modified status"

This check fires during self-host.

> The approach is simple: if a pass reports that it's not modifying a
> Function/Module, compute a loose hash of that Function/Module and compare it
> with the original one. If we report no change but there's a hash change, then we
> have an error.
>
> This approach misses a lot of change but it's not super intrusive and can
> detect most of the simple mistakes.
>
> Differential Revision: https://reviews.llvm.org/D80916

This reverts commit 3667d87a33d3c8d4072a41fd84bb880c59347dc0.