[all-commits] [llvm/llvm-project] 3f411e: [lld][WebAssembly] Fix --export-all when __stack_p...
Sam Clegg via All-commits
all-commits at lists.llvm.org
Tue Sep 15 06:20:13 PDT 2020
Branch: refs/heads/master
Home: https://github.com/llvm/llvm-project
Commit: 3f411e97739ffbdca0077d1c4fdc9c1fc1819019
https://github.com/llvm/llvm-project/commit/3f411e97739ffbdca0077d1c4fdc9c1fc1819019
Author: Sam Clegg <sbc at chromium.org>
Date: 2020-09-15 (Tue, 15 Sep 2020)
Changed paths:
A lld/test/wasm/export-all.s
M lld/wasm/SyntheticSections.h
M lld/wasm/Writer.cpp
Log Message:
-----------
[lld][WebAssembly] Fix --export-all when __stack_pointer is present
With https://reviews.llvm.org/D87537 we made it an error
to import or export a mutable global with the +mutable-globals
feature present. However the scan was of the entire symbol
table rather than just the imports or exports and the filter
didn't match exaclyt meaning the `__stack_pointer` (a mutable
global) was always triggering with error when the `--export-all`
flag was used.
This also revealed that we didn't have any test coverage for
the `--export-all` flag.
This change fixes the current breakage on the emscripten-releases
roller.
Differential Revision: https://reviews.llvm.org/D87663
More information about the All-commits
mailing list