[all-commits] [llvm/llvm-project] f07f3c: [MemorySSA] Precommit test case for PR47498.

Florian Hahn via All-commits all-commits at lists.llvm.org
Mon Sep 14 08:12:44 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f07f3c72375b872bfb988f7531d4e0485233ade1
      https://github.com/llvm/llvm-project/commit/f07f3c72375b872bfb988f7531d4e0485233ade1
  Author: Florian Hahn <flo at fhahn.com>
  Date:   2020-09-14 (Mon, 14 Sep 2020)

  Changed paths:
    M llvm/test/Analysis/MemorySSA/phi-translation.ll

  Log Message:
  -----------
  [MemorySSA] Precommit test case for PR47498.


  Commit: c4f1b3144184e4c276a7e7c801cbcd4ac3c573ba
      https://github.com/llvm/llvm-project/commit/c4f1b3144184e4c276a7e7c801cbcd4ac3c573ba
  Author: Florian Hahn <flo at fhahn.com>
  Date:   2020-09-14 (Mon, 14 Sep 2020)

  Changed paths:
    M llvm/include/llvm/Analysis/MemorySSA.h
    M llvm/lib/Analysis/MemorySSA.cpp
    M llvm/test/Analysis/MemorySSA/phi-translation.ll

  Log Message:
  -----------
  [MemorySSA] Make sure PerformedPhiTrans is updated for each visited def.

1ce82015f6d0 added a fix to restrict phi optimizations after phi
translations. But the current use of performedPhiTranslation only
checked whether phi translation happened for the first iterator and
missed cases where phi translations happens at subsequent
iterators/upwards defs.

This patch changes upward_defs_iteartor to take a pointer to a bool, so
we can easily ensure the final value includes all visited defs, while
still being able to conveniently use it with make_range & co.


Compare: https://github.com/llvm/llvm-project/compare/3b7708e2deb4...c4f1b3144184


More information about the All-commits mailing list