[all-commits] [llvm/llvm-project] 14e191: [llvm-readobj] - Cleanup implementation LLVMStyle<...

Georgii Rymar via All-commits all-commits at lists.llvm.org
Mon Sep 14 04:52:39 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 14e191a0e7c54d40327c2367b00261ac4856f4b5
      https://github.com/llvm/llvm-project/commit/14e191a0e7c54d40327c2367b00261ac4856f4b5
  Author: Georgii Rymar <grimar at accesssoftek.com>
  Date:   2020-09-14 (Mon, 14 Sep 2020)

  Changed paths:
    M llvm/test/tools/llvm-readobj/ELF/addrsig.test
    M llvm/tools/llvm-readobj/ELFDumper.cpp

  Log Message:
  -----------
  [llvm-readobj] - Cleanup implementation LLVMStyle<ELFT>::printAddrsig().

It has following issues:
1) `getStaticSymbolName` returns `std::string`, but the code
   assigns a result to `Expected<std::string>`.
2) The code uses `unwrapOrError` and never tests the error reported.

This patch fixes these issues.

Differential revision: https://reviews.llvm.org/D87507




More information about the All-commits mailing list