[all-commits] [llvm/llvm-project] e9c314: [llvm-readelf/obj] - Refine and generalize the cod...

[Georgii Rymar via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e9c314611bc97dc0d5d4ba384b8d5321f3728b16
      https://github.com/llvm/llvm-project/commit/e9c314611bc97dc0d5d4ba384b8d5321f3728b16
  Author: Georgii Rymar <grimar at accesssoftek.com>
  Date:   2020-09-14 (Mon, 14 Sep 2020)

  Changed paths:
    M llvm/test/CodeGen/AMDGPU/elf-notes.ll
    M llvm/test/tools/llvm-readobj/ELF/note-freebsd.s
    M llvm/tools/llvm-readobj/ELFDumper.cpp

  Log Message:
  -----------
  [llvm-readelf/obj] - Refine and generalize the code that is used to dump notes.

There is some code that can be shared between GNU/LLVM styles.
Also, this fixes 2 inconsistencies related to dumping unknown note types:
1) For GNU style we printed "Unknown note type: (0x00000003)" in some cases, and
   "Unknown note type (0x00000003)" (no colon) in other cases.
   GNU readelf always prints `:`. This patch removes the related code
   duplication and does the same.
2) For LLVM style in some cases we printed "Unknown note type (0x00000003)",
   but sometimes just "Unknown (0x00000003)". The latter is the right form, which
   is consistent with other unknowns that are printed in LLVM style.

Rebased on top of D87453.

Differential revision: https://reviews.llvm.org/D87454