[all-commits] [llvm/llvm-project] bfcb82: [JumpThreading] Fix an incorrect Modified status

[David via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: bfcb824ba5287f96c5b9f1009d10af37b7eb9519
      https://github.com/llvm/llvm-project/commit/bfcb824ba5287f96c5b9f1009d10af37b7eb9519
  Author: David Stenberg <david.stenberg at ericsson.com>
  Date:   2020-09-14 (Mon, 14 Sep 2020)

  Changed paths:
    M llvm/lib/Transforms/Scalar/JumpThreading.cpp
    A llvm/test/Transforms/JumpThreading/constant-fold-status.ll

  Log Message:
  -----------
  [JumpThreading] Fix an incorrect Modified status

This fixes PR47297.

When ProcessBlock() was able to constant fold the terminator's
condition, but not do any more transformations, the function would
return false, which would lead to the JumpThreading pass returning an
incorrect modified status. This patch makes so that ProcessBlock()
returns true in such cases. This will trigger an unnecessary invocation
of ProcessBlock() in such cases, but this should be rare to occur.

This was caught using the check introduced by D80916.

Reviewed By: efriedma

Differential Revision: https://reviews.llvm.org/D87392