[all-commits] [llvm/llvm-project] d751f8: [ConstantFold] Make areGlobalsPotentiallyEqual les...

Eli Friedman via All-commits all-commits at lists.llvm.org
Fri Sep 11 17:23:52 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d751f86189a7f7ef2a6fe06974a5da3349b02f20
      https://github.com/llvm/llvm-project/commit/d751f86189a7f7ef2a6fe06974a5da3349b02f20
  Author: Eli Friedman <efriedma at quicinc.com>
  Date:   2020-09-11 (Fri, 11 Sep 2020)

  Changed paths:
    M llvm/lib/IR/ConstantFold.cpp
    M llvm/test/Assembler/ConstantExprNoFold.ll
    M llvm/test/Transforms/InstCombine/2010-03-03-ExtElim.ll

  Log Message:
  -----------
  [ConstantFold] Make areGlobalsPotentiallyEqual less aggressive.

In particular, we shouldn't make assumptions about globals which are
unnamed_addr: we can fold them together with other globals.

Also while I'm here, use isInterposable() instead of trying to
explicitly name all the different kinds of weak linkage.

Fixes https://bugs.llvm.org/show_bug.cgi?id=47090

Differential Revision: https://reviews.llvm.org/D87123




More information about the All-commits mailing list