[all-commits] [llvm/llvm-project] fa2a8a: [WebAssembly] Add assembly syntax for mutable globals

Sam Clegg via All-commits all-commits at lists.llvm.org
Fri Sep 11 11:11:27 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: fa2a8acc71ffc3632b7c5ed584af8709639443f2
      https://github.com/llvm/llvm-project/commit/fa2a8acc71ffc3632b7c5ed584af8709639443f2
  Author: Sam Clegg <sbc at chromium.org>
  Date:   2020-09-11 (Fri, 11 Sep 2020)

  Changed paths:
    M lld/test/wasm/globals.s
    M llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
    M llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.cpp
    M llvm/test/MC/WebAssembly/globals.s

  Log Message:
  -----------
  [WebAssembly] Add assembly syntax for mutable globals

This adds and optional ", immutable" to the end of a `.globaltype`
declaration.  I would have prefered to match the `.wat` syntax
where immutable is the default and `mut` is the signifier for
mutable globals.  Sadly changing the default would break backwards
compat with existing assembly in the wild so I think its best
to stick with this approach.

Differential Revision: https://reviews.llvm.org/D87515




More information about the All-commits mailing list