[all-commits] [llvm/llvm-project] d445b6: [Attributor] Cleanup `::initialize` of various AAs

[Johannes Doerfert via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d445b6dfec13cdf9b9cb01582ec93548ea30ed0e
      https://github.com/llvm/llvm-project/commit/d445b6dfec13cdf9b9cb01582ec93548ea30ed0e
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2020-09-09 (Wed, 09 Sep 2020)

  Changed paths:
    M llvm/lib/Transforms/IPO/AttributorAttributes.cpp
    M llvm/test/Transforms/Attributor/ArgumentPromotion/X86/attributes.ll
    M llvm/test/Transforms/Attributor/ArgumentPromotion/X86/min-legal-vector-width.ll
    M llvm/test/Transforms/Attributor/ArgumentPromotion/X86/thiscall.ll
    M llvm/test/Transforms/Attributor/ArgumentPromotion/dbg.ll
    M llvm/test/Transforms/Attributor/ArgumentPromotion/profile.ll
    M llvm/test/Transforms/Attributor/IPConstantProp/multiple_callbacks.ll
    M llvm/test/Transforms/Attributor/IPConstantProp/pthreads.ll
    M llvm/test/Transforms/Attributor/callbacks.ll
    M llvm/test/Transforms/Attributor/dereferenceable-2.ll
    M llvm/test/Transforms/Attributor/heap_to_stack.ll
    M llvm/test/Transforms/Attributor/liveness.ll
    M llvm/test/Transforms/Attributor/misc.ll
    M llvm/test/Transforms/Attributor/noalias.ll
    M llvm/test/Transforms/Attributor/nofree.ll
    M llvm/test/Transforms/Attributor/noundef.ll

  Log Message:
  -----------
  [Attributor] Cleanup `::initialize` of various AAs

This commit cleans up the ::initialize method of various AAs in the
following ways:
  - If an associated function is required, give up on declarations.
    This was discovered as a real problem when lots of llvm.dbg.XXX
    call sites were assumed `noreturn` until proven otherwise. That
    does not make any sense and caused huge regressions and missed
    deductions.
  - Require more associated declarations for function interface AAs.
  - Use the IRAttribute::initialize to determine if function interface
    AAs can be used in IPO, don't replicate the checks (especially
    isFunctionIPOAmendable) all over the place. Arguably the function
    declaration check should be moved to some central place to.


  Commit: f9ea4501b861ecc987afb4a71266dcc83ae640ca
      https://github.com/llvm/llvm-project/commit/f9ea4501b861ecc987afb4a71266dcc83ae640ca
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2020-09-09 (Wed, 09 Sep 2020)

  Changed paths:
    M llvm/test/Transforms/Attributor/depgraph.ll

  Log Message:
  -----------
  [Attributor][NFC] Improve check lines in depgraph.ll

This adds the check lines with -NEXT so we see any change in the future.


Compare: https://github.com/llvm/llvm-project/compare/6a9a0bfc3350...f9ea4501b861