[all-commits] [llvm/llvm-project] 73a3d3: [SVE][CodeGen] Fix up warnings in sve-split-insert...

david-arm via All-commits all-commits at lists.llvm.org
Fri Sep 4 01:52:22 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 73a3d350a47fb8211c0c912134fbbcd59abc5d56
      https://github.com/llvm/llvm-project/commit/73a3d350a47fb8211c0c912134fbbcd59abc5d56
  Author: David Sherwood <david.sherwood at arm.com>
  Date:   2020-09-04 (Fri, 04 Sep 2020)

  Changed paths:
    M llvm/include/llvm/Support/TypeSize.h
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
    M llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
    M llvm/test/CodeGen/AArch64/sve-split-extract-elt.ll
    M llvm/test/CodeGen/AArch64/sve-split-insert-elt.ll

  Log Message:
  -----------
  [SVE][CodeGen] Fix up warnings in sve-split-insert/extract tests

I have fixed up some more ElementCount/TypeSize related warnings in
the following tests:

  CodeGen/AArch64/sve-split-extract-elt.ll
  CodeGen/AArch64/sve-split-insert-elt.ll

In SelectionDAG::CreateStackTemporary we were relying upon the implicit
cast from TypeSize -> uint64_t when calling MachineFrameInfo::CreateStackObject.
I've fixed this by passing in the known minimum size instead, which I
believe is fine because the associated stack id indicates whether this
is a scalable object or not.

I've also fixed up a case in TargetLowering::SimplifyDemandedBits when
extracting a vector element from a scalable vector. The result is a scalar,
hence it wasn't caught at the start of the function. If the vector is
scalable we just bail out for now.

Differential Revision: https://reviews.llvm.org/D86431




More information about the All-commits mailing list