[all-commits] [llvm/llvm-project] 6e0972: [test] Use %t instead of %T to remove race conditi...

Fangrui Song via All-commits all-commits at lists.llvm.org
Thu Sep 3 12:29:21 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6e09722b27ed4d48dfc668b0efc2aed88d701ebf
      https://github.com/llvm/llvm-project/commit/6e09722b27ed4d48dfc668b0efc2aed88d701ebf
  Author: Fangrui Song <maskray at google.com>
  Date:   2020-09-03 (Thu, 03 Sep 2020)

  Changed paths:
    M clang/test/Driver/config-file3.c
    M clang/test/Driver/target-override.c

  Log Message:
  -----------
  [test] Use %t instead of %T to remove race conditions between config-file3.c and target-override.c

Both tests operate on `%T/testbin`. If the two tests run concurrently,
one may fail.

This is likely the root cause of flaky failures reported by
https://lists.llvm.org/pipermail/llvm-dev/2020-September/144781.html

https://llvm.org/docs/CommandGuide/lit.html says:

`%T	parent directory of %t (not unique, deprecated, do not use)`

Reviewed By: dblaikie

Differential Revision: https://reviews.llvm.org/D87103




More information about the All-commits mailing list