[all-commits] [llvm/llvm-project] f0699d: [debugserver] Fix that debugserver's stop reply pa...

[Raphael Isemann via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f0699d9109143754088c26604c58f5ab3e9d4678
      https://github.com/llvm/llvm-project/commit/f0699d9109143754088c26604c58f5ab3e9d4678
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-09-03 (Thu, 03 Sep 2020)

  Changed paths:
    A lldb/test/Shell/Process/Inputs/abort.c
    A lldb/test/Shell/Process/TestAbortExitCode.test
    M lldb/tools/debugserver/source/RNBRemote.cpp

  Log Message:
  -----------
  [debugserver] Fix that debugserver's stop reply packets always return signal code 0

If our process terminates due to an unhandled signal, we are supposed to get the
signal code via WTERMSIG. However, we instead try to get the exit status via
WEXITSTATUS which just ends up always calculating signal code 0 (at least on the
macOS implementation where it just shifts the signal code bits away and we're
left with only 0 bits).

The exit status calculation on the LLDB side also seems a bit off as it claims
an exit status that is just the signal code (instead of for example 128 + signal
code), but that will be another patch.

Reviewed By: jasonmolenda

Differential Revision: https://reviews.llvm.org/D86336