[all-commits] [llvm/llvm-project] c5aa63: [lldb/Host] Add missing proc states

Jordan Rupprecht via All-commits all-commits at lists.llvm.org
Wed Sep 2 08:53:10 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c5aa63dd560b9cf5825c1e4da2a9ee53dbd772f3
      https://github.com/llvm/llvm-project/commit/c5aa63dd560b9cf5825c1e4da2a9ee53dbd772f3
  Author: Jordan Rupprecht <rupprecht at google.com>
  Date:   2020-09-02 (Wed, 02 Sep 2020)

  Changed paths:
    M lldb/source/Host/linux/Host.cpp

  Log Message:
  -----------
  [lldb/Host] Add missing proc states

The /proc/<pid>/status parsing is missing a few cases:
- Idle
- Parked
- Dead

If we encounter an unknown proc state, this leads to an msan warning. In reality, we only check that the state != Zombie, so it doesn't really matter that we handle all cases, but handle them anyway (current list: [1]). Also explicitly set it to unknown if we encounter an unknown state. There will still be an msan warning if the proc entry has no `State:` line, but that should not happen.

Use a StringSwitch to make the handling of proc states a little more compact.

[1] https://github.com/torvalds/linux/blob/master/fs/proc/array.c

Reviewed By: labath

Differential Revision: https://reviews.llvm.org/D86818




More information about the All-commits mailing list