[all-commits] [llvm/llvm-project] 7ff335: [ORC] Fix MachOPlatform's synthetic symbol depende...

lhames via All-commits all-commits at lists.llvm.org
Tue Sep 1 20:12:45 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 7ff335a25f80b8be3a1d8dd08b30453201dac132
      https://github.com/llvm/llvm-project/commit/7ff335a25f80b8be3a1d8dd08b30453201dac132
  Author: Lang Hames <lhames at gmail.com>
  Date:   2020-09-01 (Tue, 01 Sep 2020)

  Changed paths:
    M llvm/lib/ExecutionEngine/Orc/MachOPlatform.cpp

  Log Message:
  -----------
  [ORC] Fix MachOPlatform's synthetic symbol dependence registration.

A think-o in the existing code meant that dependencies were never registered.
This failure could lead to crashes rather than orderly error propagation if
initialization dependencies failed to materialize.

No test case: The bug was discovered in an out-of-tree code and requires
pathalogically misconfigured JIT to generate the original error that lead to
the crash.


  Commit: c40ce0da7189bd2ada15725a79525da13a67f3e4
      https://github.com/llvm/llvm-project/commit/c40ce0da7189bd2ada15725a79525da13a67f3e4
  Author: Lang Hames <lhames at gmail.com>
  Date:   2020-09-01 (Tue, 01 Sep 2020)

  Changed paths:
    M llvm/lib/ExecutionEngine/Orc/MachOPlatform.cpp

  Log Message:
  -----------
  [ORC] Add an early out for MachOPlatform's init-scraper plugin setup.

If there's no initializer symbol in the current MaterializationResponsibility
then bail out without installing JITLink passes: they're going to be no-ops
anyway.


Compare: https://github.com/llvm/llvm-project/compare/057028ed391f...c40ce0da7189


More information about the All-commits mailing list