[all-commits] [llvm/llvm-project] e5e05e: [lldb/test] Use @skipIfWindows for PExpectTest
Jordan Rupprecht via All-commits
all-commits at lists.llvm.org
Fri Aug 28 11:41:52 PDT 2020
Branch: refs/heads/master
Home: https://github.com/llvm/llvm-project
Commit: e5e05ecf65aba836802154279efbc8cbce6fe2ea
https://github.com/llvm/llvm-project/commit/e5e05ecf65aba836802154279efbc8cbce6fe2ea
Author: Jordan Rupprecht <rupprecht at google.com>
Date: 2020-08-28 (Fri, 28 Aug 2020)
Changed paths:
M lldb/packages/Python/lldbsuite/test/lldbpexpect.py
Log Message:
-----------
[lldb/test] Use @skipIfWindows for PExpectTest
Annotating `PExpectTest` with `@skipIfWindows` instead of marking it as an empty class will make the test runner recognize it as a test class, which should allow me to reland adb5c23f8c0d60eeec41dcbe21d1b26184e1c97d.
I don't have a windows machine to verify this works, but I did some tests using `@skipIfLinux` and they all worked as expected. In case the `pexpect` import is not at all available on windows, I moved it to within the method where it's used.
Reviewed By: labath
Differential Revision: https://reviews.llvm.org/D86745
More information about the All-commits
mailing list