[all-commits] [llvm/llvm-project] 0de146: [lldb] Fix Type::GetByteSize for pointer types

Pavel Labath via All-commits all-commits at lists.llvm.org
Thu Aug 27 06:41:31 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0de1463373918ae424cdcfeaa5b318f45c528696
      https://github.com/llvm/llvm-project/commit/0de1463373918ae424cdcfeaa5b318f45c528696
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-08-27 (Thu, 27 Aug 2020)

  Changed paths:
    M lldb/source/Symbol/Type.cpp
    M lldb/test/Shell/SymbolFile/DWARF/DW_AT_const_value.s

  Log Message:
  -----------
  [lldb] Fix Type::GetByteSize for pointer types

The function was returning an incorrect (empty) value on the first
invocation. Given that this only affected the first invocation, this
bug/typo went mostly unaffected. DW_AT_const_value were particularly
badly affected by this as the GetByteSize call is
SymbolFileDWARF::ParseVariableDIE is likely to be the first call of this
function, and its effects cannot be undone by retrying.

Depends on D86348.

Differential Revision: https://reviews.llvm.org/D86436




More information about the All-commits mailing list