[all-commits] [llvm/llvm-project] e85055: [MLIR][SPIRVToLLVM] Added a hook for descriptor se...

George Mitenkov via All-commits all-commits at lists.llvm.org
Wed Aug 26 22:50:40 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e850558cdc673edc82d13e602d1c819141ce9b3f
      https://github.com/llvm/llvm-project/commit/e850558cdc673edc82d13e602d1c819141ce9b3f
  Author: George Mitenkov <georgemitenk0v at gmail.com>
  Date:   2020-08-27 (Thu, 27 Aug 2020)

  Changed paths:
    M mlir/include/mlir/Conversion/SPIRVToLLVM/ConvertSPIRVToLLVM.h
    M mlir/lib/Conversion/SPIRVToLLVM/ConvertSPIRVToLLVM.cpp
    M mlir/lib/Conversion/SPIRVToLLVM/ConvertSPIRVToLLVMPass.cpp
    M mlir/test/Conversion/SPIRVToLLVM/memory-ops-to-llvm.mlir

  Log Message:
  -----------
  [MLIR][SPIRVToLLVM] Added a hook for descriptor set / binding encoding

This patch introduces a hook to encode descriptor set
and binding number into `spv.globalVariable`'s symbolic name. This
allows to preserve this information, and at the same time legalize
the global variable for the conversion to LLVM dialect.

This is required for `mlir-spirv-cpu-runner` to convert kernel
arguments into LLVM.

Also, a couple of some nits added:
- removed unused comment
- changed to a capital letter in the comment

Reviewed By: mravishankar

Differential Revision: https://reviews.llvm.org/D86515




More information about the All-commits mailing list