[all-commits] [llvm/llvm-project] b2b9af: [TableGen][GlobalISel] Fix tblgen optimization bug

Björn Pettersson via All-commits all-commits at lists.llvm.org
Wed Aug 26 03:11:22 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: b2b9af5a1397f15fbbef18497359245d8d221b86
      https://github.com/llvm/llvm-project/commit/b2b9af5a1397f15fbbef18497359245d8d221b86
  Author: Gabriel Hjort Åkerlund <gabriel.hjort.akerlund at ericsson.com>
  Date:   2020-08-26 (Wed, 26 Aug 2020)

  Changed paths:
    A llvm/test/TableGen/GlobalISelEmitterMatchTableOptimizer.td
    M llvm/utils/TableGen/GlobalISelEmitter.cpp

  Log Message:
  -----------
  [TableGen][GlobalISel] Fix tblgen optimization bug

When optimizing the table, PointerToAnyOperandMatchers would be
incorrectly reported as identical even though they have different
SizeInBits values. This bug was due to failing to overload the
isIdentical() method, which this patch addresses.

Reviewed By: arsenm

Differential Revision: https://reviews.llvm.org/D86199


  Commit: 5e23dc5b4702cb048f211903dacebed5a6df38d9
      https://github.com/llvm/llvm-project/commit/5e23dc5b4702cb048f211903dacebed5a6df38d9
  Author: Gabriel Hjort Åkerlund <gabriel.hjort.akerlund at ericsson.com>
  Date:   2020-08-26 (Wed, 26 Aug 2020)

  Changed paths:
    M llvm/include/llvm/CodeGen/GlobalISel/RegisterBankInfo.h

  Log Message:
  -----------
  [GlobalISel] Fix and tidy up documentation for ValueMapping class (NFC)

The documentation was missing a '*/' in '/*<2x32-bit> vadd {0, 64, VPR}',
and the example code are now aligned to improve readability.

Reviewed By: arsenm

Differential Revision: https://reviews.llvm.org/D86201


Compare: https://github.com/llvm/llvm-project/compare/99d18f79646c...5e23dc5b4702


More information about the All-commits mailing list